Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate rules_rust examples to defs.bzl and smaller rules #986

Merged
merged 6 commits into from
Oct 23, 2021

Conversation

hlopko
Copy link
Member

@hlopko hlopko commented Oct 22, 2021

This is performing migration for #591.

@google-cla google-cla bot added the cla: yes label Oct 22, 2021
@hlopko hlopko changed the title Migrate rules_rust repository to defs.bzl and smaller rules Migrate rules_rust examples to defs.bzl and smaller rules Oct 22, 2021
@hlopko hlopko marked this pull request as ready for review October 22, 2021 21:41
@UebelAndre
Copy link
Collaborator

How were the cargo-raze outputs updated? There are other pull requests looking to regenerate them and just wanna make sure everything is reproducible and nothing regresses. In the absence of a cargo-raze release, you can still cargo install the repo directly, would just like to know what commit to use.

@hlopko
Copy link
Member Author

hlopko commented Oct 22, 2021

I just built cargo-raze@HEAD by hand and installed the binary into ~/.cargo. Then did the standard cargo raze in the directory with Cargo.toml.

@UebelAndre
Copy link
Collaborator

I just built cargo-raze@HEAD by hand and installed the binary into ~/.cargo. Then did the standard cargo raze in the directory with Cargo.toml.

Got it, yeah for future readers, you can run the following to get an updated version of cargo-raze

git clone https://github.com/google/cargo-raze.git
cargo install --path ./cargo-raze/impl

to have an updated version just as if you'd installed it from crates.io

@hlopko hlopko merged commit d974e0e into bazelbuild:main Oct 23, 2021
@hlopko hlopko deleted the flip_591 branch October 23, 2021 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants